Skip to content

Conversation

cacieprins
Copy link
Contributor

@cacieprins cacieprins commented Oct 8, 2025

Additional details

Most notably in CT, when running Cypress in development mode, the STDERR marking tokens were appearing in the final cli output. This:

  • Ensures that we are not adding tokens when we shouldn't (e.g., debugging electron, internal development mode for Cypress)
  • Ensures that we are not stripping tokens when we aren't adding them
  • Refactors to make this distinction easier to determine

Steps to test

Check out and build; run cypress:run --component --project ./packages/driver, ensure no tokens exist in the output

How has the user experience changed?

PR Tasks


Note

Disables stderr tagging in Cypress development mode or when Electron verbose logging is enabled, refactors filtering/tagging logic, and updates tests and changelog.

  • stderr-filtering:
    • Tag control: Introduce tagsDisabled() to disable tags when ELECTRON_ENABLE_LOGGING=1 or CYPRESS_INTERNAL_ENV=development.
    • Filter: Simplify filter(stderr, debug, prefix) by removing disableTags param and env constant; only create FilterTaggedContent when tags are enabled.
    • TagStream: Conditionally wrap chunks via private tag(); use Buffer consistently; add verbose debug namespace.
    • logError: Route through tagsDisabled() to omit START_TAG/END_TAG when disabled.
    • Tests: Update specs to stub envs and assert no-tag behavior under disabling conditions; adjust buffer expectations.
  • Changelog: Add bugfix note about not bracketing stderr messages with verbose tags in dev/Electron logging.

Written by Cursor Bugbot for commit 2a79e6f. This will update automatically on new commits. Configure here.

@cacieprins cacieprins changed the title Fix: stderr tokens are no longer injected when in development mode fix: stderr tokens are no longer injected when in development mode Oct 8, 2025
@cacieprins cacieprins marked this pull request as ready for review October 8, 2025 13:51
@cacieprins cacieprins requested a review from AtofStryker October 8, 2025 13:52
cursor[bot]

This comment was marked as outdated.

Copy link

cypress bot commented Oct 8, 2025

cypress    Run #66355

Run Properties:  status check failed Failed #66355  •  git commit 2a79e6f041: Merge branch 'develop' into fix/stderr-tokens-dev-mode
Project cypress
Branch Review fix/stderr-tokens-dev-mode
Run status status check failed Failed #66355
Run duration 20m 11s
Commit git commit 2a79e6f041: Merge branch 'develop' into fix/stderr-tokens-dev-mode
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 9
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26705
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.27%
  Untested elements 186  
  Tested elements 158  
Accessibility  97.97%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  config-files-error-handling.cy.ts • 1 failed test • launchpad-e2e

View Output

Test Artifacts
setupNodeEvents > handles multiple config errors and then recovers Test Replay Screenshots
Failed  studio/studio.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress Studio > updates an existing test with assertions Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > stops waiting when an xhr request is canceled
    </td>
  </tr></table>
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
src/cy/commands/files > #readFile > retries to read when ENOENT
    </td>
  </tr></table>
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Screenshots

The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack info logs less readable with CYPRESS.STDERR annotations
2 participants